3082 eslint consolidation #3175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meandavejustice
force-pushed
the
3082-eslint-consolidation
branch
6 times, most recently
from
1767b06
to
b4676cd
Compare
meandavejustice
force-pushed
the
3082-eslint-consolidation
branch
2 times, most recently
from
a7045b9
to
f4c44c1
Compare
added 3 commits
November 6, 2019 21:44
- fixes mozilla#3082 - .eslintrc at root is extended in packages where necessary - eslint-plugin-fxa is still used in a couple of places - eslint-plugin-fxa and eslint-config-prettier moved to root dependency list - grunt removed from fxa-geodb, it was only being used to run eslint
meandavejustice
force-pushed
the
3082-eslint-consolidation
branch
from
f4c44c1
to
0dfe1e0
Compare
This was referenced Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency list
run eslint
eslint config changes are in one commit, while lint fixes are in the second commit