Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): update a support form functional test #3374

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

chenba
Copy link
Contributor

@chenba chenba commented Nov 15, 2019

PR #2824 updated payments server to redirect back to settings if a user
does not have any subscriptions. Subsequently the relevant functional
test was updated in PR #3147. However, there was a timing issue in the
test. Since the payments server will redirect at some point during its
rendering process, there may not be enough time to do the assertions in
the test.

This patch updates the test to not perform any assertions on the
subscriptions management page.

Part of #3364

@mozilla/fxa-devs r?

PR mozilla#2824 updated payments server to redirect back to settings if a user
does not have any subscriptions.  Subsequently the relevant functional
test was updated in PR mozilla#3147.  However, there was a timing issue in the
test.  Since the payments server will redirect at some point during its
rendering process, there may not be enough time to do the assertions in
the test.

This patch updates the test to not perform any assertions on the
subscriptions management page.

Part of mozilla#3364
Copy link
Contributor

@vladikoff vladikoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we shall find a way to add those assertions in the future, if needed

@chenba chenba merged commit 7c08e5a into mozilla:master Nov 15, 2019
@chenba chenba deleted the 3364-support-form-functional-tests branch November 15, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants