Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(l10n): fix support form l10n #7602

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

chenba
Copy link
Contributor

@chenba chenba commented Feb 23, 2021

Because:

  • there are various issues with l10n on the subscription support form

This commit:

  • use translated strings directly in templates
  • stop lowercasing translated strings with JS

Issue that this pull request solves

Closes: #7591, #7592 (l10n issues: mozilla/fxa-content-server-l10n#430 and mozilla/fxa-content-server-l10n#423)

Because:
 - there are various issues with l10n on the subscription support form

This commit:
 - use translated strings directly in templates
 - stop lowercasing translated strings with JS
@chenba chenba requested review from a team and biancadanforth February 23, 2021 15:41
@chenba
Copy link
Contributor Author

chenba commented Feb 23, 2021

chenba requested a review from biancadanforth now

I guess technically this is part of SubPlat. But it lives on the content-server. 🤷

Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[l10n] Partial translation not displayed in Support page
2 participants