Allow client to control pay window (bug 1122655) #62
Conversation
| opt = opt || {}; | ||
| opt.maxTries = opt.maxTries || undefined; | ||
| opt.pollIntervalMs = opt.pollIntervalMs || undefined; | ||
| opt = utils.defaults(opt, { |
There was a problem hiding this comment.
Not sure of this - utils.defaults() only replaces items when they're undefined. So this wouldn't really do anything. If the props of opts are undefined already these defaults won't do anything. The previous code would make things undefined if falsey which is a subtle difference (not sure if that was useful in any case).
There was a problem hiding this comment.
I think that's fine. I was listing these properties as undefined merely to document them because it seemed helpful to know what properties are valid on an options argument when looking at the top of a function definition. In other words: sigh, javascript.
There was a problem hiding this comment.
Ah ok, fair enough then. Maybe a comment with the reasoning - just for our future selves?
|
r+wc |
Allow client to control pay window (bug 1122655)
@muffinresearch r?