This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Bug 767587 (filetype) #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure it ever worked properly. Certainly doesn't now. Signed-off-by: Joe Walker <jwalker@mozilla.com>
cli.logErrors is normally true, but during testing we want to hide expected errors. Previously we manually toggled it on per test file basis, but with a tweak to helpers.js we can automatically toggle it when the command is expected to fail. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Now we report 404 errors (server not started with --websocket) to the web page properly. Signed-off-by: Joe Walker <jwalker@mozilla.com>
We previously attempted remote commands whenever we were loaded over http, but the server could (and in many cases will) have been started without the required flags. Take note of this. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Previously converters.js added all the internal converters. This makes it hard to have converters that we don't want to include by default, and everything else uses a startup() step, so we should conform. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Uses innerHTML. Not exported to Firefox. Signed-off-by: Joe Walker <jwalker@mozilla.com>
2 places where we would have used context.update() and context.updateExec() had they been available when they were written. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Just like the dangers of content-type sniffing, so we shouldn't be guessing at the type of data as we convert it. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Was only an experiment, was commented out, and isn't useful. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Having to inherit from a type exported by GCLI is annoying because it means a require step, and some fragility from inheritance. We have done some work to allow a JSON like declaration of a type (much like how a command is implemented) but previously it was only of any use if you wanted to 'extend' the selection type. This change is more consistent about copying properties allowing the implementation of any time using a JSON structure. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Unindent wrongly indented code. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Having [add|remove][Command|Type|Converter|etc] is nice, but we often want to register a bunch of things so we add a module that pulls together all the addFoo()/removeFoo() commands, and adds a addItems() and removeItems(). A command, converter, etc declares what type of thing it is using the 'item' property which should be one of 'command', 'setting', 'field', 'type' or 'converter'. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Previously many modules has startup() and shutdown() functions which was more verbose than it needed to be, and meant that we were wanting mozcmd files to register stuff in a different way to GCLI itself. This changeset is large but it just does the following: * Adds "item:..." properties to commands/converters/etc * Removes startup and shutdown functions in place of a items array * Alters the calling of startup to use addItems on the exported items * Breaks down large collections of commands/types into smaller units * Removes places where commands were duplicated between the server and the client Signed-off-by: Joe Walker <jwalker@mozilla.com>
If the parent type isn't specified then assume that we're targeting the basic top level type as a parent. Signed-off-by: Joe Walker <jwalker@mozilla.com>
We changed from BSD to ASF2.0 ages ago, but apparently some files got missed out - I suspect they were branched off before the change or something similar. Signed-off-by: Joe Walker <jwalker@mozilla.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.