Allow complex types to be null when transforming to payload format #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
commented
Jul 6, 2020
| updateParent(parent, jsonFieldName, bqFieldName, value); | ||
|
|
||
| // A record of key and value indicates we need to transformForBqSchema a map to an array. | ||
| } else if (isMapType(field)) { | ||
| expandMapType(jsonFieldName, (ObjectNode) value, field, parent, additionalProperties); |
There was a problem hiding this comment.
the exception in #1317 is thrown by this line trying to cast a literal null to ObjectNode here.
This PR fixes that by allowing null for any value passed to processField, which I believe is called on every type that is not an element of a list.
The resulting behavior omits the field, which BigQuery will interpret as an empty list if necessary.
jklukas
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1317