Skip to content

Commit

Permalink
Bug 1776084 [wpt PR 34539] - Revert "HTMLQuoteElement quote delimiter…
Browse files Browse the repository at this point in the history 
…s should be based on lang of parent", a=testonly

Automatic update from web-platform-tests
Revert "HTMLQuoteElement quote delimiters should be based on lang of parent"

This reverts commit a60add2d25a55f96e60c86cb99e6b66beb8bc54b.

Reason for revert: This CL is modifying the whole <q>'s lang but we only want it to modify the quote delimiters (q:before, q:after)

Original change's description:
> HTMLQuoteElement quote delimiters should be based on lang of parent
>
> Following the resolution of WHATWG HTML standard [1] and
> existing CSS issue [2], it has been decided that the
> auto (default) lang for <q> element should be based on the parent
> language, and not the language of the element itself.
>
> This CL makes sure to skip reading the lang attribute for <q>.
> Instead, its locale is calculated in
> CollectExtraStyleForPresentationAttribute(), using the parent's locale.
>
> [1] whatwg/html#3636
> [2] w3c/csswg-drafts#5478
>
> Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
> Fixed: 1290851
> Bug: 753671
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
> Reviewed-by: Mason Freed <masonf@chromium.org>
> Commit-Queue: Di Zhang <dizhangg@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1016481}

Bug: 753671
Change-Id: I17d9a8fa3f0d1f2223f3e5b19595f701e7b5d6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717880
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016912}

--

wpt-commits: e133a10700b571fb1af326a000c62f366ab0a685
wpt-pr: 34539
  • Loading branch information
@dizhang168 @moz-wptsync-bot
dizhang168 authored and moz-wptsync-bot committed Jun 29, 2022
1 parent 68e84d0 commit d02b83e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
5 changes: 1 addition & 4 deletions testing/web-platform/tests/css/css-content/quotes-030.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
body { font: 32px Arial, Helvetica, Noto Sans, DejaVu Sans, FreeSans, sans-serif; quotes: auto; }
</style>
<body>
<p>Test passes if the quote marks in each pair of lines match:
<p>Test passes if the quote marks in both lines match:
<p>One <q>two <q lang="ja">three <q lang="fr">four</q></q></q>
<p>One “two <span lang="ja">‘three <span lang="fr">『four』</span>’</span>”

<p>One <q>two <q lang="ja">three <q>four</q></q></q>
<p>One “two <span lang="ja">‘three 『four』’</span>”
5 changes: 1 addition & 4 deletions testing/web-platform/tests/css/css-content/reference/quotes-030-ref.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
body { font: 32px Arial, Helvetica, Noto Sans, DejaVu Sans, FreeSans, sans-serif; quotes: auto; }
</style>
<body>
<p>Test passes if the quote marks in each pair of lines match:
<p>Test passes if the quote marks in both lines match:
<p>One “two <span lang="ja">‘three <span lang="fr">『four』</span>’</span>”
<p>One “two <span lang="ja">‘three <span lang="fr">『four』</span>’</span>”

<p>One “two <span lang="ja">‘three 『four』’</span>”
<p>One “two <span lang="ja">‘three 『four』’</span>”

0 comments on commit d02b83e

Please sign in to comment.