Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default styling for q element #3636

Closed
xfq opened this issue Apr 20, 2018 · 17 comments
Closed

Default styling for q element #3636

xfq opened this issue Apr 20, 2018 · 17 comments
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. normative change topic: rendering

Comments

@xfq
Copy link
Contributor

xfq commented Apr 20, 2018

Users expect default quotation marks around quotes to conform to the conventions of a particular language. For example, en-US typically uses “ ...”, whereas in Greek text a user may expect to see «...».

In a multilingual document, the quotation marks are part of the surrounding context, and don’t depend on the language of the quoted text (I've omitted the final period of the sentence, since the location of the period is irrelevant to the issue at hand):

But Lucy replied: “Embrassez George de ma part”

If we were to add the subquote, publishers would expect to see that use English quotation marks too, unless we specifically wanted to reproduce the text being quoted exactly as it looked in the original. So we’d normally expect to see:

But Lucy replied: “Embrassez George de ma part et dites-lui, ‘Embrouille’”

instead of French quotation marks.

The i18n WG would like to propose that the version of the quotation marks should be set according to the language indicated on the html tag, and not according to the language of the quoted text.

Currently, there are two sets of tests produced by the i18n WG:

  1. https://w3c.github.io/i18n-tests/results/the-q-element.html
  2. https://www.w3.org/International/tests/repo/results/the-q-element.en.html

The first one tests the proposed behavior above, and the second one tests the behavior/rendering currently specified in the WHATWG HTML Standard.

It seems that there're no tests about <q> in WPT at the moment:

I'd be happy to port one of the tests above to WPT, preferably the first one.


For more information:

@annevk annevk added topic: rendering i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. labels Apr 20, 2018
@annevk
Copy link
Member

annevk commented Apr 20, 2018

The i18n WG would like to propose that the version of the quotation marks should be set according to the language indicated on the html tag, and not according to the language of the quoted text.

Well, that's not exactly what the rendering section does. I suspect the problem you are seeing is when the q element itself has a lang/xml:lang attribute. In that case you get the wrong result, but if you have a large section in different language that also contains some quotes, the current rendering rules seems preferable over just checking the root element.

I wonder if :root:lang(CODE), :not(:lang(CODE)) > :not(q):lang(CODE) (note the addition of :not(q)) would not be a better solution?

Also, it seems most browsers align with HTML today so this would be a breaking change to some extent? That might be acceptable though since it should strictly speaking improve things and it's unlikely to actually break sites.

@r12a
Copy link

r12a commented Apr 25, 2018

I wonder if :root:lang(CODE), :not(:lang(CODE)) > :not(q):lang(CODE) (note the addition of :not(q)) would not be a better solution?

I agree that it would be useful to allow for more than just detection of root element for default quote setting, and i think this suggestion may work for the top level of quotes. (I assume that if there's no lang on html but there is one lower down the hierarchy that this would still kick in?)

For nested quotes such as

But Lucy replied: “Embrassez George de ma part et dites-lui, ‘Embrouille’”

I think there may be 2 possible strategies:

  1. add another selector to keep the quotes the same around Embrouille.
  2. decide that in the default case it's ok for the quotes to change around Embrouille and leave as is (this produces the effect of reproducing the quotes as in the original source, rather than changing to match the outer context).

@annevk
Copy link
Member

annevk commented Apr 25, 2018

(A comma in a selector is a logical OR, so yes.)

How would my selector not have the desired effect on your nested quotes scenario? If you have <q>Something: <q>Whoa</q></q> the selector would not apply so quotes would not be changed. You would need a more contrived example. (And your example even seems simpler than that, as the nested <q> is not a different language.)

@r12a
Copy link

r12a commented Apr 25, 2018

And your example even seems simpler than that, as the nested is not a different language.

Ah, yes, you're right. Sorry. That then.

@aphillips
Copy link
Contributor

aphillips commented May 28, 2018

The I18N WG actioned me with replying on this issue, basically to say that we'd like to proceed with what's described above. Please let us know if you'd like to discuss or let me know if you'd like to attend a teleconference to discussion. [I18N-ACTION-716]

@domenic
Copy link
Member

domenic commented May 28, 2018

I think the main issue in changing anything here is gathering implementer interest. Has the WG reached out to any implementers?

@xfq
Copy link
Contributor Author

xfq commented May 29, 2018

Link to minutes: https://www.w3.org/2018/05/10-i18n-minutes.html#item05

The WG has not reached out to any implementer yet.

Complete shot in the dark: @ericwilligers and @SimonSapin, any comment on this proposal?

@frivoal
Copy link
Contributor

frivoal commented May 31, 2018

Link to a historical but fairly detailed thread on that topic (whole thread, not just initial email):
https://lists.w3.org/Archives/Public/www-international/2016AprJun/0008.html

In particular, it includes a suggestion by myself that the following pattern may be a good way to style <q> elements:

:lang(en) > *:not(q *) { quotes: "“" "”" "‘" "’" }
:lang(fr-CA) > *:not(q *) { quotes: "« " " »" "‹ " " ›" } 

@frivoal
Copy link
Contributor

frivoal commented May 31, 2018

This email probably best summarizes my position:
https://lists.w3.org/Archives/Public/www-international/2016AprJun/0090.html

@r12a
Copy link

r12a commented May 31, 2018

@xfq
Copy link
Contributor Author

xfq commented Jun 1, 2018

Here's the demo written by @frivoal: https://jsbin.com/savatoqala/edit?html,css,output

@frivoal
Copy link
Contributor

frivoal commented Jun 1, 2018

@xfq Thanks, I had forgotten about that one. Note about the demo: The selector syntax that it uses is only supported in Safari (and Vivliostyle) as of today as far as I know.

@fantasai
Copy link
Contributor

fantasai commented Feb 2, 2019

:where(:root:lang(en), [lang]:lang(en))) { curly quotes }
:where(:root:lang(fr), [lang]:lang(fr))) { guillemots}
:where(:root:lang(zh), [lang]:lang(zh))) { brackets }
q { quotes: inherit; }

I think that should mostly work as intended?

Whatever selectors are being used here, they shouldn't be difficult to evaluate. So we have to take that into consideration. Florian's selectors are pretty expensive.

@frivoal
Copy link
Contributor

frivoal commented Feb 2, 2019

Nice. This gives the same result, based on using simpler (and faster) selectors. I hadn't thought of undoing part of an overbroad selector using inheritance.

That sounds like the right solution.

@annevk
Copy link
Member

annevk commented Feb 4, 2019

@fantasai that would only work if we also discouraged xml:lang usage.

@fantasai
Copy link
Contributor

fantasai commented Feb 5, 2019

@annevk OK, there, I fixed it. :)

@namespace xml "http://www.w3.org/XML/1998/namespace";
:where(:root:lang(en), [lang]:lang(en), [xml|lang]:lang(en))) { curly quotes }
:where(:root:lang(fr), [lang]:lang(fr), [xml|lang]:lang(fr))) { guillemots}
:where(:root:lang(zh), [lang]:lang(zh), [xml|lang]:lang(fr))) { brackets }
q { quotes: inherit; }

@annevk annevk closed this as completed in 14f032e Sep 15, 2020
mfreed7 pushed a commit to mfreed7/html that referenced this issue Sep 25, 2020
The CSS spec[1] has been updated to use 'auto' as the initial value for
quotes, as resolved in [2]. The 'auto' behavior is what the HTML spec
has been trying to express. Instead, let the HTML elements have the
initial value for the quotes property and let CSS specify what 'auto'
means.

[1] https://drafts.csswg.org/css-content/#quotes-property
[2] w3c/csswg-drafts#4074

Closes whatwg#3636.
mfreed7 pushed a commit to mfreed7/html that referenced this issue Sep 25, 2020
The CSS spec[1] has been updated to use 'auto' as the initial value for
quotes, as resolved in [2]. The 'auto' behavior is what the HTML spec
has been trying to express. Instead, let the HTML elements have the
initial value for the quotes property and let CSS specify what 'auto'
means.

[1] https://drafts.csswg.org/css-content/#quotes-property
[2] w3c/csswg-drafts#4074

Closes whatwg#3636.
mfreed7 pushed a commit to mfreed7/html that referenced this issue Sep 25, 2020
The CSS spec[1] has been updated to use 'auto' as the initial value for
quotes, as resolved in [2]. The 'auto' behavior is what the HTML spec
has been trying to express. Instead, let the HTML elements have the
initial value for the quotes property and let CSS specify what 'auto'
means.

[1] https://drafts.csswg.org/css-content/#quotes-property
[2] w3c/csswg-drafts#4074

Closes whatwg#3636.
@himorin
Copy link

himorin commented Jan 29, 2021

Note: W3C i18n WG closed our tracker with actions taken satisfactory. (please not remove i18n-needs-resolution label which is used by our bot and tracking system)

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 17, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Bug: 1290851
Bug: 753671
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 17, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Bug: 1290851
Bug: 753671
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 17, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Bug: 1290851
Bug: 753671
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 17, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Fixed: 1290851
Bug: 753671
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 21, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Fixed: 1290851
Bug: 753671
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 22, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Fixed: 1290851
Bug: 753671
aarongable pushed a commit to chromium/chromium that referenced this issue Jun 22, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Fixed: 1290851
Bug: 753671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016481}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 22, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Fixed: 1290851
Bug: 753671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016481}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 22, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Fixed: 1290851
Bug: 753671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016481}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 22, 2022
…parent"

This reverts commit a60add2d25a55f96e60c86cb99e6b66beb8bc54b.

Reason for revert: This CL is modifying the whole <q>'s lang but we only want it to modify the quote delimiters (q:before, q:after)

Original change's description:
> HTMLQuoteElement quote delimiters should be based on lang of parent
>
> Following the resolution of WHATWG HTML standard [1] and
> existing CSS issue [2], it has been decided that the
> auto (default) lang for <q> element should be based on the parent
> language, and not the language of the element itself.
>
> This CL makes sure to skip reading the lang attribute for <q>.
> Instead, its locale is calculated in
> CollectExtraStyleForPresentationAttribute(), using the parent's locale.
>
> [1] whatwg/html#3636
> [2] w3c/csswg-drafts#5478
>
> Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
> Fixed: 1290851
> Bug: 753671
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
> Reviewed-by: Mason Freed <masonf@chromium.org>
> Commit-Queue: Di Zhang <dizhangg@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1016481}

Bug: 753671
Change-Id: I17d9a8fa3f0d1f2223f3e5b19595f701e7b5d6ac
aarongable pushed a commit to chromium/chromium that referenced this issue Jun 22, 2022
…parent"

This reverts commit a60add2.

Reason for revert: This CL is modifying the whole <q>'s lang but we only want it to modify the quote delimiters (q:before, q:after)

Original change's description:
> HTMLQuoteElement quote delimiters should be based on lang of parent
>
> Following the resolution of WHATWG HTML standard [1] and
> existing CSS issue [2], it has been decided that the
> auto (default) lang for <q> element should be based on the parent
> language, and not the language of the element itself.
>
> This CL makes sure to skip reading the lang attribute for <q>.
> Instead, its locale is calculated in
> CollectExtraStyleForPresentationAttribute(), using the parent's locale.
>
> [1] whatwg/html#3636
> [2] w3c/csswg-drafts#5478
>
> Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
> Fixed: 1290851
> Bug: 753671
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
> Reviewed-by: Mason Freed <masonf@chromium.org>
> Commit-Queue: Di Zhang <dizhangg@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1016481}

Bug: 753671
Change-Id: I17d9a8fa3f0d1f2223f3e5b19595f701e7b5d6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717880
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016912}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 23, 2022
…parent"

This reverts commit a60add2d25a55f96e60c86cb99e6b66beb8bc54b.

Reason for revert: This CL is modifying the whole <q>'s lang but we only want it to modify the quote delimiters (q:before, q:after)

Original change's description:
> HTMLQuoteElement quote delimiters should be based on lang of parent
>
> Following the resolution of WHATWG HTML standard [1] and
> existing CSS issue [2], it has been decided that the
> auto (default) lang for <q> element should be based on the parent
> language, and not the language of the element itself.
>
> This CL makes sure to skip reading the lang attribute for <q>.
> Instead, its locale is calculated in
> CollectExtraStyleForPresentationAttribute(), using the parent's locale.
>
> [1] whatwg/html#3636
> [2] w3c/csswg-drafts#5478
>
> Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
> Fixed: 1290851
> Bug: 753671
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
> Reviewed-by: Mason Freed <masonf@chromium.org>
> Commit-Queue: Di Zhang <dizhangg@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1016481}

Bug: 753671
Change-Id: I17d9a8fa3f0d1f2223f3e5b19595f701e7b5d6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717880
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016912}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 23, 2022
…parent"

This reverts commit a60add2d25a55f96e60c86cb99e6b66beb8bc54b.

Reason for revert: This CL is modifying the whole <q>'s lang but we only want it to modify the quote delimiters (q:before, q:after)

Original change's description:
> HTMLQuoteElement quote delimiters should be based on lang of parent
>
> Following the resolution of WHATWG HTML standard [1] and
> existing CSS issue [2], it has been decided that the
> auto (default) lang for <q> element should be based on the parent
> language, and not the language of the element itself.
>
> This CL makes sure to skip reading the lang attribute for <q>.
> Instead, its locale is calculated in
> CollectExtraStyleForPresentationAttribute(), using the parent's locale.
>
> [1] whatwg/html#3636
> [2] w3c/csswg-drafts#5478
>
> Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
> Fixed: 1290851
> Bug: 753671
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
> Reviewed-by: Mason Freed <masonf@chromium.org>
> Commit-Queue: Di Zhang <dizhangg@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1016481}

Bug: 753671
Change-Id: I17d9a8fa3f0d1f2223f3e5b19595f701e7b5d6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717880
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016912}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 29, 2022
… be based on lang of parent, a=testonly

Automatic update from web-platform-tests
HTMLQuoteElement quote delimiters should be based on lang of parent

Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Fixed: 1290851
Bug: 753671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016481}

--

wpt-commits: 1f7f1a2bdcd5966e090ae5310ee3359b3d717c45
wpt-pr: 34485
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 29, 2022
…s should be based on lang of parent", a=testonly

Automatic update from web-platform-tests
Revert "HTMLQuoteElement quote delimiters should be based on lang of parent"

This reverts commit a60add2d25a55f96e60c86cb99e6b66beb8bc54b.

Reason for revert: This CL is modifying the whole <q>'s lang but we only want it to modify the quote delimiters (q:before, q:after)

Original change's description:
> HTMLQuoteElement quote delimiters should be based on lang of parent
>
> Following the resolution of WHATWG HTML standard [1] and
> existing CSS issue [2], it has been decided that the
> auto (default) lang for <q> element should be based on the parent
> language, and not the language of the element itself.
>
> This CL makes sure to skip reading the lang attribute for <q>.
> Instead, its locale is calculated in
> CollectExtraStyleForPresentationAttribute(), using the parent's locale.
>
> [1] whatwg/html#3636
> [2] w3c/csswg-drafts#5478
>
> Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
> Fixed: 1290851
> Bug: 753671
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
> Reviewed-by: Mason Freed <masonf@chromium.org>
> Commit-Queue: Di Zhang <dizhangg@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1016481}

Bug: 753671
Change-Id: I17d9a8fa3f0d1f2223f3e5b19595f701e7b5d6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717880
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016912}

--

wpt-commits: e133a10700b571fb1af326a000c62f366ab0a685
wpt-pr: 34539
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Jun 30, 2022
… be based on lang of parent, a=testonly

Automatic update from web-platform-tests
HTMLQuoteElement quote delimiters should be based on lang of parent

Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Fixed: 1290851
Bug: 753671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016481}

--

wpt-commits: 1f7f1a2bdcd5966e090ae5310ee3359b3d717c45
wpt-pr: 34485
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Jun 30, 2022
…s should be based on lang of parent", a=testonly

Automatic update from web-platform-tests
Revert "HTMLQuoteElement quote delimiters should be based on lang of parent"

This reverts commit a60add2d25a55f96e60c86cb99e6b66beb8bc54b.

Reason for revert: This CL is modifying the whole <q>'s lang but we only want it to modify the quote delimiters (q:before, q:after)

Original change's description:
> HTMLQuoteElement quote delimiters should be based on lang of parent
>
> Following the resolution of WHATWG HTML standard [1] and
> existing CSS issue [2], it has been decided that the
> auto (default) lang for <q> element should be based on the parent
> language, and not the language of the element itself.
>
> This CL makes sure to skip reading the lang attribute for <q>.
> Instead, its locale is calculated in
> CollectExtraStyleForPresentationAttribute(), using the parent's locale.
>
> [1] whatwg/html#3636
> [2] w3c/csswg-drafts#5478
>
> Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
> Fixed: 1290851
> Bug: 753671
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
> Reviewed-by: Mason Freed <masonf@chromium.org>
> Commit-Queue: Di Zhang <dizhangg@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1016481}

Bug: 753671
Change-Id: I17d9a8fa3f0d1f2223f3e5b19595f701e7b5d6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717880
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016912}

--

wpt-commits: e133a10700b571fb1af326a000c62f366ab0a685
wpt-pr: 34539
aarongable pushed a commit to chromium/chromium that referenced this issue Aug 16, 2022
…Object

Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

We change the function QuoteContentData::CreateLayoutObject so that
the ComputedStyle for the pseudo children of the <q> element will
use its parent locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: I5eb7c7dcdc4f2c73e99880598b230c02652ec953
Bug: 753671
Fixed: 1290851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3795145
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1035697}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

This CL makes sure to skip reading the lang attribute for <q>.
Instead, its locale is calculated in
CollectExtraStyleForPresentationAttribute(), using the parent's locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
Fixed: 1290851
Bug: 753671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016481}
NOKEYCHECK=True
GitOrigin-RevId: a60add2d25a55f96e60c86cb99e6b66beb8bc54b
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
…parent"

This reverts commit a60add2d25a55f96e60c86cb99e6b66beb8bc54b.

Reason for revert: This CL is modifying the whole <q>'s lang but we only want it to modify the quote delimiters (q:before, q:after)

Original change's description:
> HTMLQuoteElement quote delimiters should be based on lang of parent
>
> Following the resolution of WHATWG HTML standard [1] and
> existing CSS issue [2], it has been decided that the
> auto (default) lang for <q> element should be based on the parent
> language, and not the language of the element itself.
>
> This CL makes sure to skip reading the lang attribute for <q>.
> Instead, its locale is calculated in
> CollectExtraStyleForPresentationAttribute(), using the parent's locale.
>
> [1] whatwg/html#3636
> [2] w3c/csswg-drafts#5478
>
> Change-Id: Ief17dd1e7f5a40112899ce898fa672a6fef6e834
> Fixed: 1290851
> Bug: 753671
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704149
> Reviewed-by: Mason Freed <masonf@chromium.org>
> Commit-Queue: Di Zhang <dizhangg@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1016481}

Bug: 753671
Change-Id: I17d9a8fa3f0d1f2223f3e5b19595f701e7b5d6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717880
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016912}
NOKEYCHECK=True
GitOrigin-RevId: 296cfd40ace1b39d0a5fc57e6ef80f16147f324e
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
…Object

Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.

We change the function QuoteContentData::CreateLayoutObject so that
the ComputedStyle for the pseudo children of the <q> element will
use its parent locale.

[1] whatwg/html#3636
[2] w3c/csswg-drafts#5478

Change-Id: I5eb7c7dcdc4f2c73e99880598b230c02652ec953
Bug: 753671
Fixed: 1290851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3795145
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1035697}
NOKEYCHECK=True
GitOrigin-RevId: 5a60b6ed73df08da8efbf35305fc9d30a7e96362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. normative change topic: rendering
Development

No branches or pull requests

8 participants