Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reads non-conformant capabilities from New Session body #206

Closed
andreastt opened this issue Sep 1, 2016 · 4 comments
Closed

Reads non-conformant capabilities from New Session body #206

andreastt opened this issue Sep 1, 2016 · 4 comments

Comments

@andreastt
Copy link
Contributor

The WebDriver specification says that the desired- and required capabilities should be contained inside a capabilities JSON object, like this:

{
  capabilities: {
    desiredCapabilities: <object>,
    requiredCapabilities: <object>
  }
}

This differs from how Selenium sends capabilities:

{
  desiredCapabilities: <object>,
  requiredCapabilities: <object>
}

geckodriver seems to support only the latter, making it non-conformant to the spec.

@andreastt
Copy link
Contributor Author

Or I guess part of the problem here is that I was assuming firefoxOptions would be read from one of desiredCapabilities and requiredCapabilities. This might not be the case.

@jgraham jgraham modified the milestone: 0.11 Sep 7, 2016
@jgraham
Copy link
Member

jgraham commented Sep 8, 2016

Deferring this since the capabilities setup may undergo further churn.

@andreastt
Copy link
Contributor Author

This is now fixed as part of the new-New Session negotiation and https://bugzilla.mozilla.org/show_bug.cgi?id=1326534, available in Firefox 52 onwards.

@lock
Copy link

lock bot commented Aug 17, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have run into an issue you think is related, please open a new issue.

@lock lock bot locked and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants