Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using OSX on travis #125

Merged
merged 1 commit into from Jun 30, 2016
Merged

Build using OSX on travis #125

merged 1 commit into from Jun 30, 2016

Conversation

jgraham
Copy link
Member

@jgraham jgraham commented Jun 29, 2016

This change is Reviewable

@jgraham jgraham changed the title DO NOT MERGE: Build using OSX on travis Build using OSX on travis Jun 30, 2016
@jgraham
Copy link
Member Author

jgraham commented Jun 30, 2016

r? @andreastt

@andreastt
Copy link
Contributor

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


a discussion (no related file):
Looks like you accidentally changed all the indentation from tabs to spaces in ci.sh.


.travis.yml, line 58 [r1] (raw file):

    - "geckodriver-$TRAVIS_TAG-arm7hf.tar.gz"
    - "geckodriver-$TRAVIS_TAG-linux64.tar.gz"
    - "geckodriver-$TRAVIS-osx.tar.gz"

Missing the _TAG from $TRAVIS_TAG.


ci.sh, line 101 [r1] (raw file):

        ;;
    x86_64-apple-darwin)
        target=osx

Apple changed the official name of Mac OS X to “macOS” a few weeks ago, so we should use that since X is being phased out.


Comments from Reviewable

@andreastt
Copy link
Contributor

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@andreastt
Copy link
Contributor

Review status: all files reviewed at latest revision, all discussions resolved.


a discussion (no related file):

Previously, andreastt (Andreas Tolfsen) wrote…

Looks like you accidentally changed all the indentation from tabs to spaces in ci.sh.

Okay, I’m going to accept this under in the hope that we will soon get rid of (most of) this file.

Comments from Reviewable

@andreastt
Copy link
Contributor

@jgraham LGTM, but please squash first.

@jgraham jgraham merged commit 567e2f5 into master Jun 30, 2016
@whimboo whimboo deleted the travis_osx branch June 6, 2017 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants