Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trace logs safe for windows prompt #722

Merged
merged 1 commit into from
May 8, 2017
Merged

Make trace logs safe for windows prompt #722

merged 1 commit into from
May 8, 2017

Conversation

andreastt
Copy link
Contributor

@andreastt andreastt commented May 8, 2017

The symbols "←" and "→" are encodeed as "?" in the Windows command
prompt. To make the logs from this system useful, use ASCII versions
of the arrows.


This change is Reviewable

The symbols "←" and "→" are encodeed as "?" in the Windows command
prompt.  To make the logs from this system useful, use ASCII versions
of the arrows.
@andreastt andreastt requested a review from mjzffr May 8, 2017 13:41
@andreastt
Copy link
Contributor Author

See also mozilla/webdriver-rust#96.

@jgraham
Copy link
Member

jgraham commented May 8, 2017

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jgraham jgraham merged commit 60e7a43 into mozilla:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants