Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribution view doesn't capture x-axis labels correctly for categorical probes #2693

Open
Iinh opened this issue Feb 7, 2024 · 2 comments · Fixed by #2779
Open

Distribution view doesn't capture x-axis labels correctly for categorical probes #2693

Iinh opened this issue Feb 7, 2024 · 2 comments · Fixed by #2779
Assignees
@edugfilho

Comments

@Iinh
Copy link
Contributor

Iinh commented Feb 7, 2024

Categorical probes such as enumerated, categorical etc have x-axis labels as NaN

CleanShot 2024-02-07 at 09 38 42@2x
@edugfilho
Copy link
Collaborator

How to reproduce:
Access a categorical probe (example), right click the Proportions chart to bring out the context menu, then select Distribution Comparison. Notice the x-axis labels read NaN

@edugfilho
Copy link
Collaborator

edugfilho commented Feb 26, 2024 •
edited
Loading

Is it mandatory that we fix this before making GLAM public?

@edugfilho edugfilho self-assigned this Apr 1, 2024
edugfilho added a commit that referenced this issue Apr 2, 2024
@edugfilho
#2693 Improves Distribution Comparison for categorical probes (#2779)
3c6e684 
* Multiple fixes on Dist Comp for categorical probes

* Don't show unselected categories on Dist Comp chart

* lint + prettier
@edugfilho edugfilho mentioned this issue Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edugfilho edugfilho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2693 Improves Distribution Comparison for categorical probes mozilla/glam
2 participants
@edugfilho @Iinh