-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1143: Add SQL example using main_1pct #1162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff.
Can you link to the cookbook somewhere in the modal? I don't think we should assume it's generally known (I keep on telling people about it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good! Can you show some screenshots as well?
src/components/SqlModal.svelte
Outdated
href="https://docs.telemetry.mozilla.org/cookbooks/main_ping_exponential_histograms.html"> | ||
Visualizing Percentiles of a Main Ping Exponential Histogram</a> | ||
for more on the use of this query. | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the screenshot, I'm wondering if it would look better if we pasted this text into the SQL statement as a comment. It looks a little weird to have this just below the ... :
f85ce7b
to
4d70d46
Compare
Squashed and added screenshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the nitpicking, but what do you think about moving the copy/paste icon into the text area? Similar to what's done on dtmo:
https://docs.telemetry.mozilla.org/cookbooks/main_ping_exponential_histograms.html#getting-client-level-data
src/components/SqlModal.svelte
Outdated
href="https://docs.telemetry.mozilla.org/cookbooks/main_ping_exponential_histograms.html"> | ||
Visualizing Percentiles of a Main Ping Exponential Histogram</a> | ||
for more on the use of this query. | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the screenshot, I'm wondering if it would look better if we pasted this text into the SQL statement as a comment. It looks a little weird to have this just below the ... :
I did consider that initially but it would mean refactoring the way I'm showing the SQL which is currently just in a textarea. But since you bring it up it sounds like that would be worthwhile to spend extra time on that. I changed it in this code from a button at the bottom since the telemetry SQL is so long and it is not longer visible at the bottom.
I could just get rid of the ellipsis and reword it so it's not necessary. I think the link works well there. |
Not sure how hard it would be! If it's not too much trouble I would try that.
That seems like a reasonable solution to me. |
4d70d46
to
a9fd883
Compare
Thanks for all the reviews, @wlach! |
Updated modal with telemetry SQL tab selected...
![Screenshot_2021-02-09 tls_delegated_credentials_time_until_ready_ms GLAM(1)](https://user-images.githubusercontent.com/1106/107443422-a7351780-6aed-11eb-9234-5125ea14f679.png)