Fix #1143: Add SQL example using main_1pct #1162
Conversation
There was a problem hiding this comment.
This is great stuff.
Can you link to the cookbook somewhere in the modal? I don't think we should assume it's generally known (I keep on telling people about it).
src/components/SqlModal.svelte
Outdated
| href="https://docs.telemetry.mozilla.org/cookbooks/main_ping_exponential_histograms.html"> | ||
| Visualizing Percentiles of a Main Ping Exponential Histogram</a> | ||
| for more on the use of this query. | ||
| </p> |
There was a problem hiding this comment.
Looking at the screenshot, I'm wondering if it would look better if we pasted this text into the SQL statement as a comment. It looks a little weird to have this just below the ... :
robhudson
force-pushed
the
1143-main-1pct-sql
branch
from
f85ce7b
to
4d70d46
Compare
|
Squashed and added screenshot |
src/components/SqlModal.svelte
Outdated
| href="https://docs.telemetry.mozilla.org/cookbooks/main_ping_exponential_histograms.html"> | ||
| Visualizing Percentiles of a Main Ping Exponential Histogram</a> | ||
| for more on the use of this query. | ||
| </p> |
There was a problem hiding this comment.
Looking at the screenshot, I'm wondering if it would look better if we pasted this text into the SQL statement as a comment. It looks a little weird to have this just below the ... :
I did consider that initially but it would mean refactoring the way I'm showing the SQL which is currently just in a textarea. But since you bring it up it sounds like that would be worthwhile to spend extra time on that. I changed it in this code from a button at the bottom since the telemetry SQL is so long and it is not longer visible at the bottom.
I could just get rid of the ellipsis and reword it so it's not necessary. I think the link works well there. |
Not sure how hard it would be! If it's not too much trouble I would try that.
That seems like a reasonable solution to me. |
robhudson
force-pushed
the
1143-main-1pct-sql
branch
from
4d70d46
to
a9fd883
Compare
|
Thanks for all the reviews, @wlach! |
Updated modal with telemetry SQL tab selected...
