Fix glean metrics not showing after fix for Categorical probes #2817
Conversation
| let isCategoricalProbe = | ||
| $store.probe.details && $store.probe.details.kind === 'categorical'; |
There was a problem hiding this comment.
would this only work with Glean metrics? how about categorical histograms?
There was a problem hiding this comment.
My understanding is we want it to be true iff it's a Legacy probe and it's categorical, no?
There was a problem hiding this comment.
Legacy probes have details whereas Glean metrics don't. Categorical histograms have to have isCategoricalProbe === true
There was a problem hiding this comment.
ah yea thanks for the clarification. could you remind me why we don't need to check for categorical glean probes here - distribution comparison is not available for glean probes yet?
There was a problem hiding this comment.
I didn't think Glean had categorical probes. I did a quick look up at Glean dictionary and didn't find any. Oh, are they under a different name?
There was a problem hiding this comment.
I think Glean boolean probes have categorical view in Glam, but will need to check if we even display these.
Line 75 in f0228a3
There was a problem hiding this comment.
hm, if that's the case GLAM doesn't support boolean probes
This fixes the bug introduced in #2779, which searches for a field that's not present into Glean metrics' metadata.