Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table search only searches in last part of the component #80

Closed
wlach opened this issue Oct 9, 2020 · 4 comments
Closed

Table search only searches in last part of the component #80

wlach opened this issue Oct 9, 2020 · 4 comments
Assignees

Comments

@wlach
Copy link
Contributor

wlach commented Oct 9, 2020

This issue is intended as an onboarding task for potential outreachy applicants. Please do not work on it unless you have completed the initial qualification task and it has been assigned to you.

Currently the filter search in the table view (e.g. http://localhost:5000/#!/apps/mach/tables/usage) only filters for content in the last "node" in the structure. e.g. if you have

client_info.app_version
client.info.app_display_version
client_info.client_id
...

and you search for "client", it will filter out all of the above except for client_info.client_id. Ideally the search would include all entries whose parent elements have the term in them (in the example above, this would be everything that includes client).

To fix this, you'll need to edit the schemaviewer component:

const filterTextChanged = (filterText = "") => {

@wlach wlach added the outreachy label Oct 9, 2020
@wlach
Copy link
Contributor Author

wlach commented Oct 9, 2020

Going to assign this to @hngerebara

@UdokaVrede
Copy link

Hi wlach how can I locate the initial qualification task

@mhmohona
Copy link
Contributor

Hello @UdokaVrede! I am another outreachy applicant like you but as @wlach is currently on vacation and will be available from Monday, I am replying you.

In project Outreachy website you will find details about initial qualification task.

These are steps mentioned there in website -

The first step of the application process is to:

  • If you haven't used Svelte before (which is ok!), run through at least some of their interactive tutorial: https://svelte.dev/tutorial/basics
  • Checkout the glean dictionary project (https://github.com/mozilla/glean-dictionary)
  • Following the instructions in the README, extract and process the dataset information and get a local copy of the site running
  • Find the "usage ping" BigQuery table for the "mach" application and find the client_info.app_channel column. Using your text editor and the locally checked out source, make it so that the description of the column is shown in RED rather than the current colour of GREY
  • Take a screenshot and create a diff of the changes you made to make this change, and DM these to wlach on chat.mozilla.org (see the project communications channels) along with your GitHub user id

@UdokaVrede
Copy link

UdokaVrede commented Oct 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants