Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1888430 - Add page_id to Glean automatic events #1919

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Bug 1888430 - Add page_id to Glean automatic events #1919

merged 1 commit into from
Apr 22, 2024

Conversation

travis79
Copy link
Member

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@travis79 travis79 marked this pull request as ready for review April 19, 2024 16:32
@travis79
Bug 1888430 - Adds a page_id metric
096e18f 
This adds a UUID metric `page_id` which is rotated with each page_load event,
and is sent on every events ping in order to associate events to a particular
page load.
rosahbruno
rosahbruno approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@rosahbruno rosahbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I will just leave this here until we get confirmation from Wil that everything looks ok, then we can land it.

@travis79 travis79 merged commit c5aa793 into main Apr 22, 2024
5 of 6 checks passed
@travis79 travis79 deleted the Bug1888430 branch April 22, 2024 21:02
rosahbruno added a commit to rosahbruno/glean.js that referenced this pull request Apr 26, 2024
@rosahbruno
missing changelogs for mozilla#1919 & mozilla#1921
9322932
rosahbruno added a commit that referenced this pull request Apr 26, 2024
@rosahbruno
Merge pull request #1922 from rosahbruno/missing-changelogs
b1156ba 
missing changelogs for #1919 & #1921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosahbruno rosahbruno rosahbruno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travis79 @rosahbruno