Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1893015 - Fix an issue where experimentation-id wasn't making it into certain pings #1921

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

travis79
Copy link
Member

This fixes the way the experimentation id was getting added to pings that didn't have other metrics already in the payload.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from Dexterp37 April 24, 2024 13:42
@travis79 travis79 requested review from rosahbruno and removed request for Dexterp37 April 24, 2024 13:42
@rosahbruno rosahbruno merged commit 12dea1f into main Apr 24, 2024
5 of 6 checks passed
@rosahbruno rosahbruno deleted the Bug1893015 branch April 24, 2024 14:51
rosahbruno added a commit to rosahbruno/glean.js that referenced this pull request Apr 26, 2024
rosahbruno added a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants