Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .nojekyll in docs-deploy step #1938

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

rosahbruno
Copy link
Contributor

This should fix the issue we are seeing where the docs have no styling or JS since GitHub pages is ignoring directories starting with an underscore

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from travis79 May 14, 2024 14:30
@rosahbruno rosahbruno merged commit bb7c7db into mozilla:main May 14, 2024
5 of 6 checks passed
@rosahbruno rosahbruno deleted the docs-nojekyll branch May 14, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants