Bug 1679381 - Implement the datetime metric type #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
commented
Jan 4, 2021
brizental
commented
Jan 4, 2021
brizental
commented
Jan 4, 2021
brizental
commented
Jan 4, 2021
brizental
commented
Jan 4, 2021
brizental
force-pushed
the
1679381-datetime-2
branch
from
6e71241
to
c3d16f7
Compare
Dexterp37
requested changes
Jan 7, 2021
Dexterp37
reviewed
Jan 7, 2021
added 2 commits
January 7, 2021 17:36
The Javascript date object is _always_ relative to the local timezone. So if the user submitted in a different timezone than the they record the datetime details (hour, day, etc) were not respected.
Dexterp37
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #19 thus it is blocked by it.
I am opening anyways to illustrate how the changes added by #19 can be used in a more complex way than the cases in #19 itself.
The commit that matters here is fb5c0e8. All the other are part of #19.