Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALTERNATE] Bug 1689547 - Create plugin / events infrastructure and define afterPingCollection event #95

Merged
merged 9 commits into from
Mar 4, 2021
Merged

[ALTERNATE] Bug 1689547 - Create plugin / events infrastructure and define afterPingCollection event #95

merged 9 commits into from
Mar 4, 2021

Conversation

brizental
Copy link
Contributor

Different approach for #94 (and my preferred approach, 1) Less cleverness on the types 2) Less relying on the Glean singleton).

Based off of this thread.

Dexterp37
Dexterp37 approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach more than the previous one, thanks for taking time to go through this again. I appreciate the effort!

glean/src/core/events/index.ts Show resolved Hide resolved
glean/src/core/glean.ts Show resolved Hide resolved
@brizental brizental mentioned this pull request Mar 4, 2021
Closed
@brizental brizental merged commit b1407e8 into mozilla:main Mar 4, 2021
@brizental brizental deleted the 1689547-plugins-ALTERNATE branch March 4, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brizental @Dexterp37