Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1657852 - Transform ping dir size to kB before accumulating #1236

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Bug 1657852 - Transform ping dir size to kB before accumulating #1236

merged 2 commits into from
Sep 29, 2020

Conversation

brizental
Copy link
Contributor

@brizental brizental commented Sep 28, 2020 •
edited
Loading

Dexterp37
Dexterp37 approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc. I wish the "note" at the bottom of this page was at the top :)

glean-core/src/upload/mod.rs Show resolved Hide resolved
@brizental brizental merged commit a722b95 into mozilla:main Sep 29, 2020
@brizental brizental deleted the 1657852-fix-dir-size-acc branch September 29, 2020 08:44
badboy pushed a commit that referenced this pull request Oct 1, 2020
@badboy
Bug 1657852 - Transform ping dir size to kB before accumulating (#1236)
ccac992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brizental @Dexterp37