Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Automatically substitute glean's version in forUnitTest dependencies #441

Closed

Conversation

Dexterp37
Copy link
Contributor

This attempts to find the version of the Glean SDK currently being used in projects using the gradle plugin and to add that version as a constraint to any forUnitTest glean dependency available.

Note this is currently lacking the constraint part

Todo:

  • Add a dependency constraint to enable using forUnitTest dependencies without a version number
  • Remove the changes to .buildconfig.yml
  • Add to the changelog

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #441 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #441      +/-   ##
============================================
+ Coverage     76.49%   76.51%   +0.01%     
+ Complexity      330      329       -1     
============================================
  Files            96       96              
  Lines          5463     5462       -1     
  Branches        631      631              
============================================
  Hits           4179     4179              
+ Misses          820      819       -1     
  Partials        464      464
Impacted Files Coverage Δ Complexity Δ
...ozilla/telemetry/glean/debug/GleanDebugActivity.kt 76.66% <0%> (+0.9%) 6% <0%> (-1%) ⬇️
...in/java/mozilla/telemetry/glean/utils/JsonUtils.kt 83.33% <0%> (+8.33%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b2eee...63a669a. Read the comment docs.

@mdboom
Copy link
Contributor

mdboom commented Nov 5, 2019

I might be missing something, but I think we have a chicken-and-egg problem here. User libraries would include the Glean plugin by specifying a Glean version. The plugin can then provide a Glean version, but they need to know it in the first place.

(Or maybe I'm just missing something about how this would work in practice...)

@Dexterp37 Dexterp37 closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants