Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and disallow mdbook errors #466

Merged
merged 1 commit into from Nov 11, 2019
Merged

Fix and disallow mdbook errors #466

merged 1 commit into from Nov 11, 2019

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Nov 11, 2019

When mdbook reports errors, it doesn't actually return a UNIX error code. So there were include directives inserted into the docs that were "broken" but still passed CI.

I filed this issue with mdbook: rust-lang/mdBook#1094

In the meantime, we can use grep to detect errors and return an error code from CI.

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #466 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #466      +/-   ##
============================================
+ Coverage     76.68%   76.69%   +0.01%     
  Complexity      330      330              
============================================
  Files            96       96              
  Lines          5554     5557       +3     
  Branches        630      631       +1     
============================================
+ Hits           4259     4262       +3     
  Misses          831      831              
  Partials        464      464
Impacted Files Coverage Δ Complexity Δ
...a/telemetry/glean/net/HttpURLConnectionUploader.kt 91.11% <0%> (+0.63%) 14% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ef779...b6719b2. Read the comment docs.

@mdboom mdboom merged commit 26baf8d into mozilla:master Nov 11, 2019
@mdboom mdboom deleted the fix-docs branch April 14, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants