Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and disallow mdbook errors #466

Merged
merged 1 commit into from Nov 11, 2019
Merged

Fix and disallow mdbook errors #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion bin/build-rust-docs.sh
View file
Open in desktop
Expand Up @@ -8,7 +8,13 @@ set -e
CRATE_NAME=glean_core

pushd docs &&
mdbook build &&
mdbook build |& grep "\[ERROR\]" &&
if [ $? -eq 0 ]
then
exit 1
else
exit 0
fi
popd

cargo doc --no-deps
Expand Down
8 changes: 4 additions & 4 deletions docs/user/pings/custom.md
View file
Open in desktop
Expand Up @@ -37,7 +37,7 @@ search:

The Glean SDK build generates code from `pings.yaml` in a `Pings` object, which must be instantiated so Glean can send pings by name.

{{#include ../tab_header.md}}
{{#include ../../tab_header.md}}

<div data-lang="Kotlin" class="tab">

Expand Down Expand Up @@ -67,7 +67,7 @@ pings = load_pings("pings.yaml")

</div>

{{#include ../tab_footer.md}}
{{#include ../../tab_footer.md}}

## Sending metrics in a custom ping

Expand Down Expand Up @@ -99,7 +99,7 @@ To send a custom ping, call the `send` method on the `PingType` object that the

For example, to send the custom ping defined above:

{{#include ../tab_header.md}}
{{#include ../../tab_header.md}}

<div data-lang="Kotlin" class="tab">

Expand All @@ -118,4 +118,4 @@ pings.search.send()

</div>

{{#include ../tab_footer.md}}
{{#include ../../tab_footer.md}}