Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade glean_parser to 1.20.1 #827

Merged
merged 10 commits into from
May 4, 2020
Merged

Upgrade glean_parser to 1.20.1 #827

merged 10 commits into from
May 4, 2020

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Apr 15, 2020

No description provided.

@auto-assign auto-assign bot requested a review from Dexterp37 April 15, 2020 16:40
@Dexterp37
Copy link
Contributor

Oh, interesting failure.

mozilla.telemetry.glean.GleanTest > sending an empty ping doesn't queue work STANDARD_OUT
[Robolectric] mozilla.telemetry.glean.GleanTest.sending an empty ping doesn't queue work: sdk=28; resources=BINARY
thread '' panicked at 'No database found', glean-core/src/lib.rs:456:10

@mdboom
Copy link
Contributor Author

mdboom commented Apr 16, 2020

Oh, interesting failure.

mozilla.telemetry.glean.GleanTest > sending an empty ping doesn't queue work STANDARD_OUT
[Robolectric] mozilla.telemetry.glean.GleanTest.sending an empty ping doesn't queue work: sdk=28; resources=BINARY
thread '' panicked at 'No database found', glean-core/src/lib.rs:456:10

I just filed a bug for this.

@mdboom mdboom force-pushed the upgrade-glean-parser-1.20.0 branch from 7de300f to f0ec7ff Compare April 17, 2020 13:26
@mdboom
Copy link
Contributor Author

mdboom commented Apr 20, 2020

Let's wait until mozilla-mobile/fenix#10056 is merged so that this won't create a "time bomb" if we upgrade glean in a-c first.

@mdboom mdboom changed the title Upgrade glean_parser to 1.20.0 WIP: Upgrade glean_parser to 1.20.0 Apr 20, 2020
@mdboom mdboom changed the title WIP: Upgrade glean_parser to 1.20.0 WIP: Upgrade glean_parser to 1.20.1 Apr 21, 2020
@mdboom mdboom force-pushed the upgrade-glean-parser-1.20.0 branch from 58844e8 to c63c9e1 Compare April 21, 2020 19:33
@mdboom
Copy link
Contributor Author

mdboom commented Apr 21, 2020

This now includes the reduced version numbers from glean_parser 1.20.1, which necessitates testing with minimum Python versions of the dependencies to make sure we aren't inadvertently using newer APIs.

@mdboom mdboom marked this pull request as draft April 23, 2020 13:43
@mdboom mdboom force-pushed the upgrade-glean-parser-1.20.0 branch 3 times, most recently from 1b63b5c to a5b7d64 Compare April 30, 2020 19:45
@mdboom mdboom marked this pull request as ready for review April 30, 2020 20:06
@mdboom mdboom changed the title WIP: Upgrade glean_parser to 1.20.1 Upgrade glean_parser to 1.20.1 Apr 30, 2020
@auto-assign auto-assign bot requested a review from travis79 April 30, 2020 20:08
@travis79
Copy link
Member

Interesting to know that auto-assign bot will run again if you change the title of the PR...

@mdboom mdboom force-pushed the upgrade-glean-parser-1.20.0 branch from fba3c2f to f068dd9 Compare May 4, 2020 15:53
@mdboom mdboom merged commit bc8c697 into mozilla:master May 4, 2020
@mdboom mdboom deleted the upgrade-glean-parser-1.20.0 branch May 4, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

@travis79 travis79 travis79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdboom @Dexterp37 @travis79