Don't run travis CI when modifying appveyor.yml #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #207.
So the issue was that the commit range was turning into
FETCH_HEAD...master
. The behaviour for runninggit diff
with two endpoints separated by...
is specified here. The important part is that it deals with differences up to the second endpoint, in this casemaster
, which means there were no file changes. You can see this in travis where there is an empty line.I think the original PR for fb should have had
$TRAVIS_BRANCH..FETCH_HEAD
or$TRAVIS_BRANCH...FETCH_HEAD
instead ofFETCH_HEAD...$TRAVIS_BRANCH
which makes almost no sense because a pr will almost always be ahead of the target branch.Also, the modification to the
TRAVIS_COMMIT_RANGE
environment variable was unnecessary once travis-ci/travis-core#383 was merged.