-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge new UI into production branch (#130)
* GUD v2 (graph-paper revamp) (#85) * adds barebones from graph-paper story * integrates config file * adds back Logo; further tweaks to menu items; implements cache + querying * adds Loading Spinner * finesses error / loading states * adds calls to action (feedback, shortcuts, docs, file an issue) in Sidebar * adds esc * further tweaks to Shortcuts menu * styling tweaks * adds back querystring state loading * updates store to have a no-local querying approach to support transitions within Explore.svelte * adds back in TimeAxis.svelte * updates and tweaks some layout pieces * updates the mouseovers to account for bug fixes (contingent on a new graph-paper PR) * adds back in caveat system * adds smoothing option * adds hash routing for future improvements * fixes the hashbang routing with query parameteres * wires up explore body menus to read from querystring * metric selector; moves some compoinents to src/components/controls * compartmentalizes the mouse interactions * adds back in markers * cleans up modal implementatino * sidebar tweaks * adds a few more affordances around YoY + mouseovers; cleans up all menus * feature-complete * adds disabledMetrics and disabledDimensions * makes lists keyboard-accessible * restyles sidebar in anticipation of multiple views * migrates to graph-paper 0.0.0-alpha.14 * improves mouseover performance * further design tweaks * adds in changes to usage criterion from prototype branch * adds newer clickOutside action * reset start and end dates on usage criterion change * removes extraneous comments * updates a handful of dependencies * adds back tooltips into graphs * adds TitleMenu.svelte component * Consolidates routing / config information * adds disabled functionality * adds rudimeentary scrollIntoView support * adds CHANGELOG.md * date picker closes after apply is clicked (#97) * moves around a few components; fixes DatePicker animation issue (#102) * moves around a few components; fixes DatePicker animation issue * collapses DatePicker on reset * removes buttons in explore when focused on a single metric * Add basic front-end CI tests (#103) * ESLint improvements (#105) * Switch to a Node-based eslint-health script * Run ESLint against Svelte files * Update eslint-health.js with small docs changes * Remove appId labels from Fenix channels (#107) Should wait until mozilla/bigquery-etl#1245 is merged. The mapping from Fenix channels to appIds is no longer straight-forward, so we remove those shortDescription values. * bugfixes before fbo tomorrow (#111) * Add Japan to the country list (#114) Resolves #112 Relies on mozilla/bigquery-etl#1352 to make JP available in the underlying tables. * Never use "Fennec" for "Firefox for iOS" (#120) * Remove references to folks no longer involved (#125) * redirects / to /explore, which fixes future instantiation issues because the route is not codified in the hash. (#124) * uses labels instead of keys for sidebar and body title (#123) * Remove usage criteria docs, which are out of date (#126) This same documentation exists in the UI, so I think it's best to remove it here. * Adjust to modified product names (#128) See mozilla/bigquery-etl#1380 Co-authored-by: Hamilton Ulmer <hamilton.ulmer@gmail.com> Co-authored-by: John Karahalis <john.karahalis@gmail.com>
- Loading branch information
3 people
committed
Jan 6, 2021
1 parent
40b9440
commit 8145549
Showing
83 changed files
with
16,862 additions
and
8,324 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| version: 2 | ||
| jobs: | ||
| frontend-tests: | ||
| working_directory: ~/mozilla/gud | ||
| docker: | ||
| - image: circleci/node:11.5 | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: update-npm | ||
| command: 'sudo npm install -g npm@latest' | ||
| - restore_cache: | ||
| key: dependency-cache-{{ checksum "package-lock.json" }} | ||
| - run: | ||
| name: install-npm-wee | ||
| command: npm install | ||
| - save_cache: # special step to save the dependency cache | ||
| key: dependency-cache-{{ checksum "package-lock.json" }} | ||
| paths: | ||
| - ./node_modules | ||
| - run: npm run build | ||
| - run: node scripts/eslint-health.js | ||
|
|
||
| workflows: | ||
| version: 2 | ||
| test-and-deploy: | ||
| jobs: | ||
| - frontend-tests: | ||
| filters: | ||
| tags: | ||
| only: /.*/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| !.eslintrc.js | ||
|
|
||
| public/bundle.* | ||
| docs/js/jquery*.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,69 @@ | ||
| module.exports = { | ||
| parserOptions: { | ||
| ecmaVersion: 2019, | ||
| sourceType: "module" | ||
| sourceType: "module", | ||
| }, | ||
| env: { | ||
| browser: true | ||
| browser: true, | ||
| es6: true, | ||
| }, | ||
| plugins: ["prettier"], | ||
| extends: ["prettier"], | ||
| extends: ["airbnb-base"], | ||
| plugins: ["jest", "svelte3"], | ||
| rules: { | ||
| "prettier/prettier": "error" | ||
| } | ||
| "import/prefer-default-export": "off", | ||
| "import/no-extraneous-dependencies": ["error", { devDependencies: true }], | ||
| "no-param-reassign": [ | ||
| "error", | ||
| { props: true, ignorePropertyModificationsFor: ["draft"] }, | ||
| ], | ||
| }, | ||
| overrides: [ | ||
| { | ||
| files: ["**/*.js"], | ||
| extends: ["prettier"], | ||
| plugins: ["prettier"], | ||
| rules: { | ||
| "prettier/prettier": "error", | ||
| }, | ||
| }, | ||
| { | ||
| files: ["**/*.svelte"], | ||
| processor: "svelte3/svelte3", | ||
|
|
||
| // Turn off all rules that might conflict with Prettier.[1] Note that this | ||
| // does not warn if a Svelte file disobeys Prettier rules. That's what the | ||
| // Prettier *plugin* does, but at the time of this writing, the | ||
| // eslint-plugin-svelte3 plugin discourages the use of the Prettier | ||
| // plugin for Svelte files.[2] | ||
| // | ||
| // [1] https://github.com/prettier/eslint-config-prettier | ||
| // [2] https://github.com/sveltejs/eslint-plugin-svelte3/blob/6900d670c9e85509b2d21decd91f1e75f7934596/OTHER_PLUGINS.md#eslint-plugin-prettier | ||
| extends: ["prettier"], | ||
|
|
||
| rules: { | ||
| "prefer-const": "off", | ||
|
|
||
| // Disable rules that do not work correctly with eslint-plugin-svelte3 | ||
| // | ||
| // https://github.com/sveltejs/eslint-plugin-svelte3/blob/6900d670c9e85509b2d21decd91f1e75f7934596/OTHER_PLUGINS.md#eslint-plugin-import | ||
| "import/first": "off", | ||
| "import/no-duplicates": "off", | ||
| "import/no-mutable-exports": "off", | ||
| "import/no-unresolved": "off", | ||
|
|
||
| // Temporarily work around a bug in eslint-plugin-svelte3. | ||
| // | ||
| // https://github.com/sveltejs/eslint-plugin-svelte3/issues/41#issuecomment-572503966 | ||
| "no-multiple-empty-lines": ["error", { max: 2, maxBOF: 2, maxEOF: 0 }], | ||
| }, | ||
| }, | ||
| { | ||
| files: ["tests/**/*.test.js"], | ||
| plugins: ["jest"], | ||
| extends: ["plugin:jest/recommended", "plugin:jest/style"], | ||
| env: { | ||
| jest: true, | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Changelog | ||
|
|
||
| ## unreleased | ||
|
|
||
| - Revamp GUD to use `graph-paper` components ([#85](https://github.com/mozilla/gud/pull/85)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.