GUD v2 (graph-paper revamp) #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions within Explore.svelte
jklukas
added a commit
that referenced
this pull request
Jan 6, 2021
* GUD v2 (graph-paper revamp) (#85) * adds barebones from graph-paper story * integrates config file * adds back Logo; further tweaks to menu items; implements cache + querying * adds Loading Spinner * finesses error / loading states * adds calls to action (feedback, shortcuts, docs, file an issue) in Sidebar * adds esc * further tweaks to Shortcuts menu * styling tweaks * adds back querystring state loading * updates store to have a no-local querying approach to support transitions within Explore.svelte * adds back in TimeAxis.svelte * updates and tweaks some layout pieces * updates the mouseovers to account for bug fixes (contingent on a new graph-paper PR) * adds back in caveat system * adds smoothing option * adds hash routing for future improvements * fixes the hashbang routing with query parameteres * wires up explore body menus to read from querystring * metric selector; moves some compoinents to src/components/controls * compartmentalizes the mouse interactions * adds back in markers * cleans up modal implementatino * sidebar tweaks * adds a few more affordances around YoY + mouseovers; cleans up all menus * feature-complete * adds disabledMetrics and disabledDimensions * makes lists keyboard-accessible * restyles sidebar in anticipation of multiple views * migrates to graph-paper 0.0.0-alpha.14 * improves mouseover performance * further design tweaks * adds in changes to usage criterion from prototype branch * adds newer clickOutside action * reset start and end dates on usage criterion change * removes extraneous comments * updates a handful of dependencies * adds back tooltips into graphs * adds TitleMenu.svelte component * Consolidates routing / config information * adds disabled functionality * adds rudimeentary scrollIntoView support * adds CHANGELOG.md * date picker closes after apply is clicked (#97) * moves around a few components; fixes DatePicker animation issue (#102) * moves around a few components; fixes DatePicker animation issue * collapses DatePicker on reset * removes buttons in explore when focused on a single metric * Add basic front-end CI tests (#103) * ESLint improvements (#105) * Switch to a Node-based eslint-health script * Run ESLint against Svelte files * Update eslint-health.js with small docs changes * Remove appId labels from Fenix channels (#107) Should wait until mozilla/bigquery-etl#1245 is merged. The mapping from Fenix channels to appIds is no longer straight-forward, so we remove those shortDescription values. * bugfixes before fbo tomorrow (#111) * Add Japan to the country list (#114) Resolves #112 Relies on mozilla/bigquery-etl#1352 to make JP available in the underlying tables. * Never use "Fennec" for "Firefox for iOS" (#120) * Remove references to folks no longer involved (#125) * redirects / to /explore, which fixes future instantiation issues because the route is not codified in the hash. (#124) * uses labels instead of keys for sidebar and body title (#123) * Remove usage criteria docs, which are out of date (#126) This same documentation exists in the UI, so I think it's best to remove it here. * Adjust to modified product names (#128) See mozilla/bigquery-etl#1380 Co-authored-by: Hamilton Ulmer <hamilton.ulmer@gmail.com> Co-authored-by: John Karahalis <john.karahalis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65, closes #66, closes #67, closes #68, closes #69, closes #70, closes #71, closes #72, closes #73, closes #74, closes #80
This PR is non-functional on other machines since I am using
npm linkto pull in a few unpublished graph paper changes that enable functionality.graph-paper0.0.0-alpha.14mode=whateverto proper hash-based routes