-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Admin Panel UI for account deletion #5716
Conversation
5e1a5bb
to
69b7bc7
Compare
Rebased |
</Button> | ||
)} | ||
|
||
{deleteState === deleteStates.confirming && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be nice to add a new function like this
/**
* compare state
* @return boolean
*/
const isDeleteState = useCallback(
state => {
return state === deleteState;
},
[deleteState]
);
and then refactor ones like this to..
{isDeleteState(Confirming) && (
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing here is a blocker - feel free to take any of the changes suggested but I don't see any errors,
82b5c12
to
fa7b8f9
Compare
Squashed |
Adds a delete button to the account edit screen in the admin panel. Includes a confirmation dialog and states. Also removes the bulk delete capability from the account list.
Goes with Hubs-Foundation/reticulum#628