Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of GSM / UMTS cell ids ranges #304

Closed
hannosch opened this issue Sep 2, 2014 · 3 comments
Closed

Add validation of GSM / UMTS cell ids ranges #304

hannosch opened this issue Sep 2, 2014 · 3 comments
Assignees
Labels

Comments

@hannosch
Copy link
Contributor

hannosch commented Sep 2, 2014

We currently have some GSM cells with cell ids larger than 64k and some UMTS cells with cell ids lower than 64k.

In both of these cases the radio type is likely wrong. Many older Android chipsets don't properly distinguish between GSM/UMTS and so we end up getting the wrong type.

We should normalize the radio type based on the cell id value. This applies both to the submission data as well as the search interface and needs a migration of existing cells.

@hannosch hannosch added the bug label Sep 2, 2014
@Gitschubser
Copy link

I have do a simple check with the file MLS-full-cell-export-2014-10-23T000000.csv.

Radio Type GSM:
24892 cells have the radio type GSM and a cellid >65535

-> 7721 cells have only 1 sample

Radio Type UMTS:
19906 have the radio type UMTS and a cellid <65536

-> 6638 cells have only 1 sample

Maybe there are 44798 cellids wrong or doesn't exist?

A good task could validate the data (only a short example from me, maybe there are another ideas)

GSM

  1. Check if radio type is GSM and the cellid has a range between 0 and 65535 (<65536).
  2. If yes, radio type is correct, if no data is false.
  3. If false, check if the cellid (mcc_mnc_lac_cellid) exists with another radio type (duplicate)
  4. If cellid exists with another radio type, delete the wrong data (how we find the wrong data?)
  5. If cellid exists not with another radio type change to the right radio type.

UMTS

  1. Check if radio type is UMTS and the cellid is >65535.
  2. If yes, radio type is correct, if no radio type is false.
  3. If false, check if the cellid (mcc_mnc_lac_cellid) exists with another radio type (duplicate)
  4. If cellid exists with another radio type, delete the wrong data (how we find the wrong data?)
  5. If cellid exists not with another radio type change to the right radio type.

Maybe i have not regard all possibilities.

@E3V3A
Copy link

E3V3A commented Oct 23, 2014

From Open Cell ID site:

CID     must be in the range of 1 to 65535 for GSM
CID     must be in the range of 1 to 4294967295 for UMTS
CID     must be in the range 1 to 268435455 for LTE
CID/BID     must be in the range 1 to 65535 for CDMA 

jaredlockhart added a commit to JaredLockhart-Mozilla/ichnaea that referenced this issue Nov 10, 2014
- Update cell processing to catch incorrect radio types
- Add test
- Add data migration
jaredlockhart added a commit to JaredLockhart-Mozilla/ichnaea that referenced this issue Nov 14, 2014
- Update cell processing to catch incorrect radio types
- Add test
- Add data migration
jaredlockhart added a commit to JaredLockhart-Mozilla/ichnaea that referenced this issue Nov 14, 2014
- Update cell processing to catch incorrect radio types
- Add test
- Add data migration
jaredlockhart added a commit to JaredLockhart-Mozilla/ichnaea that referenced this issue Nov 14, 2014
- Update cell processing to catch incorrect radio types
- Add test
- Add data migration
jaredlockhart added a commit to JaredLockhart-Mozilla/ichnaea that referenced this issue Nov 14, 2014
- Update cell processing to catch incorrect radio types
- Add test
- Add data migration
jaredlockhart added a commit to JaredLockhart-Mozilla/ichnaea that referenced this issue Nov 14, 2014
- Update cell processing to catch incorrect radio types
- Add test
- Add data migration
jaredlockhart added a commit to JaredLockhart-Mozilla/ichnaea that referenced this issue Nov 14, 2014
- Update cell processing to catch incorrect radio types
- Add test
- Add data migration
jaredlockhart added a commit that referenced this issue Nov 17, 2014
- Update cell processing to catch incorrect radio types
- Add test
- Add data migration
@jas19
Copy link

jas19 commented Jan 14, 2016

How can we check the missing cell_id counts while migrating the data from one source to another ?
I am getting 10000 events on the target one but the actual records should be 30000.
How to check this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants