Skip to content
This repository has been archived by the owner on Sep 3, 2020. It is now read-only.

Stop testing Node v0.10 #87

Merged
merged 1 commit into from
Mar 27, 2015
Merged

Stop testing Node v0.10 #87

merged 1 commit into from
Mar 27, 2015

Conversation

jbuck
Copy link
Member

@jbuck jbuck commented Mar 27, 2015

No description provided.

@jbuck
Copy link
Member Author

jbuck commented Mar 27, 2015

@alicoding @cadecairos @gvn @k88hudson @Pomax @simonwex any objections to not caring about node v0.10?

@Pomax
Copy link
Contributor

Pomax commented Mar 27, 2015

💥

jbuck added a commit that referenced this pull request Mar 27, 2015
@jbuck jbuck merged commit b5c36ab into mozilla:develop Mar 27, 2015
@k88hudson
Copy link
Contributor

Hm, actually isn't it recommended that we stick to node v0.10? I have found 0.12 to be somewhat buggy, especially with older code...

@simonwex
Copy link
Contributor

Buggy how?

@jbuck
Copy link
Member Author

jbuck commented Mar 27, 2015

I already merged it, but I'm happy to back it out too. I guess what this patch does here is just remove CI for node v0.10. I hadn't even considered using node v0.10 for staging, I was planning on using node 0.12 for staging.

I looked for some recommendations, and Eran Hammer, former head of Walmart Mobile says 0.10 or iojs.

@Pomax
Copy link
Contributor

Pomax commented Mar 27, 2015

one of the major wins here is npm 2.5 -- but that said, I'd also like to know where 0.12 is still considered buggy

@toolness
Copy link
Contributor

I'm not sure what k88 means by "buggy" but I have run into problems w/ running slightly older code on 0.12 due to API breakages in some of the experimental core node APIs and such, e.g. gulp-community/gulp-less#140. In the case of the Teach site it's actually preferable for us to use a slightly older version of LESS but we can't because it doesn't support 0.12 and, um, my computer has 0.12 on it ... and I'm lazy I guess?

@Pomax
Copy link
Contributor

Pomax commented Mar 27, 2015

the older version of less is pretty behind at this point though, 3.x should be 0.12 compatible and have a number of fixes compared to the 2.x version

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants