[Bug 797399] Fix wiki.models.Document.from_url() #1140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the doc string for that was never correct. See 00bbc85 I assume |
|
I've updated the docstring. Thanks Ricky. |
| parent=d_en, save=True) | ||
| self.assertEqual(d_en.translated_to('tr'), | ||
| from_url(d_en.translated_to('tr').get_absolute_url())) | ||
| print d_en.get_absolute_url() |
There was a problem hiding this comment.
This is an errant print. Can you remove it, please?
|
Thanks for the review. I think I addressed all of your comments. |
|
I'll look at this again tomorrow. Sorry I didn't get to it today. |
|
Looks good! I squashed the commits and landed it in master in 6233f3e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=797399
There is a misleading sentence in the docstring of
Document.from_url():I can't find the
host_safeparameter in the wiki application.