Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug 913958] Persona sign in button in AAQ flow #1640

Closed
wants to merge 2 commits into from
Closed

[bug 913958] Persona sign in button in AAQ flow #1640

wants to merge 2 commits into from

Conversation

rehandalal
Copy link
Contributor

r?

@rlr
Copy link
Contributor

rlr commented Sep 23, 2013

Doesn't this mean you can delete a bunch of persona auth stuff from the view now?

@rlr
Copy link
Contributor

rlr commented Sep 23, 2013

works amazing! I think it should clean up the view a bunch, especially once we go full persona.

@rlr
Copy link
Contributor

rlr commented Sep 23, 2013

should we do the same for mobile?

@rehandalal
Copy link
Contributor Author

they say you should never go FULL persona.
http://www.youtube.com/watch?v=X6WHBO_Qc-Q

@rehandalal
Copy link
Contributor Author

i'll make the changes to mobile and delete extra code from the view.

@rehandalal
Copy link
Contributor Author

updated ^

@rlr
Copy link
Contributor

rlr commented Sep 23, 2013

fantástico r+

@rehandalal
Copy link
Contributor Author

73bb8f9

@rehandalal rehandalal closed this Sep 24, 2013
@snyk-bot snyk-bot mentioned this pull request Jun 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rehandalal @rlr