Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug 673948] Use display name on Questions #1770

Closed
wants to merge 2 commits into from
Closed

[Bug 673948] Use display name on Questions #1770

wants to merge 2 commits into from

Conversation

kudrom
Copy link
Contributor

@kudrom kudrom commented Dec 17, 2013

No description provided.

@rlr
Copy link
Contributor

rlr commented Dec 17, 2013

hi! You passed the username into the display_name helper but you should be passing the actual user. Pretty sure that's why travis is unhappy about this: https://travis-ci.org/mozilla/kitsune/builds/15580668

@kudrom
Copy link
Contributor Author

kudrom commented Dec 19, 2013

Hi
Sorry for the delay, i've deleted the changes to the email templates because in all of them what is passed is solely the username, must i add support to them as well?
Thanks

@rlr
Copy link
Contributor

rlr commented Dec 19, 2013

Looks good! I'll run it and double check everything before landing. Thanks!

@rlr
Copy link
Contributor

rlr commented Dec 19, 2013

Thank you! 0f2d0eb

@rlr rlr closed this Dec 19, 2013
@kudrom kudrom deleted the display_name_questions branch December 22, 2013 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kudrom @rlr