[Bug 1058671] Cache geoip results. #2091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cookies with the geoip results. If these cookies are present, the geoip script will not be included. These cookies expire after 30 days.
| @@ -234,7 +234,10 @@ | |||
| {% endif %} | |||
| {# End Optimizely #} | |||
|
|
|||
| <script src="//geo.mozilla.org/country.js" type="text/javascript"></script> | |||
| {% if include_geoip %} | |||
There was a problem hiding this comment.
I assume we'll add a and request.locale == 'en-US' here for that other request Kadir had.
There was a problem hiding this comment.
Well, I think we should add that in the context manager (less logic in templates and all that), but I also am not super excited about that particular change. I guess we should probably do it though.
|
Fixed the console.log stuff, added a 30 day expiry (instead of a session expiry) and only show it to en-US users. ^ |
|
Oh, and I added the tests I forgot to commit earlier, plus an extra pair for en-US/de checking. |
|
nice! r+ |
This was referenced Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cookies with the geoip results. If these cookies are present, the geoip script will not be included. These cookies expire after 30 days.
r?