[bug 1079413] Make certain contributor articles collapsible. #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -200,7 +206,7 @@ def list_documents(request, category=None): | |||
| except KeyError: | |||
| raise Http404 | |||
|
|
|||
| docs = paginate(request, docs, per_page=DOCUMENTS_PER_PAGE) | |||
| docs = paginate(request, docs, per_page=config.DOCUMENTS_PER_PAGE) | |||
There was a problem hiding this comment.
Did you move this settings from __init__.py to config.py? Or was it already moved and the code has just been broken for a while?
There was a problem hiding this comment.
Oh, I just did this import kitsune.wiki as config but you are right. We have been using config.py for this stuff. Let me move it there.
There was a problem hiding this comment.
Oh. I didn't notice import kitsune.wiki as config. That seems really strange, I wouldn't do that.
|
Yeah, that's what we used to do before, or maybe it was |
|
That's much less confusing, thanks! r+ |
|
7cc4323 [bug 1079413] Make certain contributor articles collapsible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for a test, so I just put the articles list in the config. If this catches on, we'll want it to be in a db column or some special markup inside each article.
The actual code that does the collapsing already existed, I just tweaked it so it wouldn't default the first section to open.
r?