[bug 1056298] Fix createsuperuser #2245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a patch call to manage.py. The problem is that various Django-specific subcommands at some point import Jingo which eventually results in a circular import. Adding the patch call here guarantees that Jingo and all that stuff is imported before we import the things we need to import to execute the subcommand.
|
I feel like we keep adding this and then removing it and then adding it again. This fixes createsuperuser. I tested some other important ones to make sure nothing broke: syncdb, shell, check, validate, inspectdb and dbshell. Everything seems fine. |
|
wfm r+ |
|
wfr1cky r+ |
|
58541af [bug 1056298] Fix createsuperuser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a patch call to manage.py. The problem is that various
Django-specific subcommands at some point import Jingo which eventually
results in a circular import. Adding the patch call here guarantees
that Jingo and all that stuff is imported before we import the things we
need to import to execute the subcommand.
r?