[Bug 1083434] Send notifications to SimplePush. #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs about Simple Push are here, though they are very light on the server side: https://developer.mozilla.org/en-US/docs/Web/API/Simple_Push_API |
|
Test it on stage/prod? This all looks good to me. If it is broken, only celery tasks should be affected so no biggie. r+ |
|
We probably can't even test this until BuddyUp writes some stuff. Chicken and egg, I guess. We can push this to stage and stare at it for a bit to make sure nothing blows up. |
mythmon
added a commit
that referenced
this pull request
Feb 4, 2015
[Bug 1083434] Send notifications to SimplePush.
This was referenced Jul 10, 2020
This was referenced Aug 16, 2020
This was referenced Mar 22, 2022
This was referenced Mar 23, 2022
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really have a good way to test this. I can't run a simple push server, and I don't think anything but a Firefox OS phone can run the client side of this. I could probably code up a simple test instance, but I don't really want to. I wrote tests that assert at least we call the URL that is registered.
r?