[Bug 1131143] Add cohort analysis script. #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only on my first coffee today, but this looks right at first glance. Not sure what's up with travis. |
|
Travis had a hiccup with npm, I guess? Its fixed now. |
|
Is this done? What is the plan for running it? |
|
Yeah, this is done. The plan for running it is that someone like like Kadir will clone kitsune and get a database set up and run the script. if this looks like it is measuring what it should be measuring, we're done here. |
rlr
added a commit
that referenced
this pull request
Apr 7, 2015
[Bug 1131143] Add cohort analysis script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic seems right to me, but I can't really tell if the numbers are right, because nothing else tells us this info. Can someone check that this approach seems right?
r?