Make showfor more resilient to missing data. #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wfm. r+ |
rehandalal
added a commit
that referenced
this pull request
Feb 4, 2016
Make showfor more resilient to missing data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone pointed out that the minimal KB view wasn't loading images. It turns out this is because showfor was trying to load non-existent data and crashing, taking down everything else with it (including lazy loading images).
This doesn't fix the issue of showfor data not being on the minimal page, but it does make showfor not crash and burn the page to the ground, which helps this particular issue.
@rehandalal r?