[bug 1241661] Calculate CSAT metrics #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '/surveyresponse?' | ||
| 'filter[field][0]=datesubmitted' | ||
| '&filter[operator][0]=>=&filter[value][0]={start}+0:0:0' | ||
| 'filter[field][1]=datesubmitted' |
There was a problem hiding this comment.
Should this have an '&' at the beginning here?
There was a problem hiding this comment.
funny that it doesn't complain about this when i run the cronjob
|
This looks fine. That URL is sort of nasty, but I don't think there is any reasonable way to improve it. My above issue about a missing Does this need a new API for the front end? Or do existing APIs cover this already? @brittanystoroz Does this look good to you? |
|
I was going to put the API stuff in another PR once this landed, but it probably makes sense to just include it here, so that's what I did. ^ |
|
This looks good to me. Lets do it. r+ |
mythmon
pushed a commit
that referenced
this pull request
Feb 25, 2016
[bug 1241661] Calculate CSAT metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still trying to figure out this campaign thing. But I figured I should push this so at least the front-end work can be unblocked.
r?