[Bug 1248594] Use MLS for GeoIP detection #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,10 +237,6 @@ | |||
| {% endif %} | |||
| {# End Optimizely #} | |||
|
|
|||
| {% if include_geoip %} | |||
There was a problem hiding this comment.
I think include_geoip is now unused, and can be removed. It is defined here.
|
This is so much nicer. I'm glad they did the new API as JSON instead of JS. |
|
Can we add a comment like Snippets did asking people not to directly use our key? |
brittanydionigi
force-pushed
the
geo-detection
branch
from
6289b85
to
a3b63dd
Compare
|
@mythmon this has been updated with the changes you requested & travis is happy :) |
|
@brittanystoroz remove the past commits that are made by others. |
|
whoa, must have messed up my rebase. thanks for noticing @safwanrahman |
brittanydionigi
force-pushed
the
geo-detection
branch
from
a3b63dd
to
79658e8
Compare
|
Wooh, thanks! |
mythmon
pushed a commit
that referenced
this pull request
Feb 29, 2016
[Bug 1248594] Use MLS for GeoIP detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching over from geo.mozilla.org to MLS for geoIP detection as outlined in bug 1248594