New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating pytest #2818
Updating pytest #2818
Conversation
# sha256: f60wfCePxbGNJ9V6zO0x6euZ90zMyBccMJhi7eu7orc | ||
# sha256: 1anD2zUVq5WQK6CMCdHpQaIaRA3C1l8xusAmZ1CKnvw | ||
pytest==2.7.3 | ||
# sha256: b61TzL8JA8aduT1nuD31IIGLBsdZftioQHvF_f_V5A4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the requirements have two hashes: one for the source package and one for the wheel. You can use a tool like hashin to easily add both hashes to the requirements file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we does not use wheel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually pip prefers wheels over source distributions, I'm pretty sure. It will work without the hash because pip will fall back to the source distribution, but if there's a wheel available pip will use that first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yap. But we had a decission to not use wheel in kitsune.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, you're right. I wonder why all our packages still have two hashes then?
Oh well!
Test failure is odd and doesn't look related; I'm rerunning them. |
Hooray! Tests work! Add that second hash and this is good to merge! |
No description provided.