[Bug 1260987] Make "en-US" locale code not localizable #2827
Conversation
|
I think about transforming all |
|
Should do the above mentioned as part of this PR? If not here or not at all, r? |
| @@ -16,7 +16,7 @@ | |||
| <div class="inline-controls"> | |||
| <div> | |||
| <select id="toggle-cohort-type"> | |||
| <option value="contributor:kb:en-US">{{ _('en-US') }}</option> | |||
| <option value="contributor:kb:en-US">{{ '%(locale)s'|format(locale='en-US') }}</option> | |||
There was a problem hiding this comment.
This can be just "en-US". As a string. I think the formatting is not needed and also a comment should be there about it not available for localization.
|
PR updated. |
| @@ -16,7 +16,8 @@ | |||
| <div class="inline-controls"> | |||
| <div> | |||
| <select id="toggle-cohort-type"> | |||
| <option value="contributor:kb:en-US">{{ _('en-US') }}</option> | |||
| <!-- The locale code is not localizable - the data are for English only. --> | |||
There was a problem hiding this comment.
The backend jinja template comment should be something like
{# Some Comment #}
There was a problem hiding this comment.
+1 to change this to a jinja comment
|
I have reviewed the patch and seems like it needs some minor correction. @rehandalal As you have worked closely with it, can you please review? |
|
r+ from me. |
|
thanks! r+ |
No description provided.