706948 no replies #506
Closed
706948 no replies #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self.question.answers.count() was pulling from cache, so when we create a new Answer, it wasn't reflected in the count and then question.num_answers would be 0 which was a mismatch. This forces it to come from the db and not cache and thus we get the right answer.
|
Looks good to me. r+ |
| @@ -425,7 +424,10 @@ def save(self, no_update=False, no_notify=False, *args, **kwargs): | |||
| super(Answer, self).save(*args, **kwargs) | |||
|
|
|||
| if new: | |||
| self.question.num_answers = self.question.answers.count() | |||
| # Need to pull from uncached, otherwise we get the cached | |||
| # query which doesn't reflect the answer we just saved. | |||
There was a problem hiding this comment.
Interesting, since COUNT queries aren't cached, afaik.
There was a problem hiding this comment.
So, I think this was a screwup on my part. I had cache machine caching counts locally and didn't discover it until after this went out. I'm now using cache settings more like what's on stage.
Given that I had "bad settings", this should get backed out since the comment is wrong and the code change shouldn't have any effect.
There was a problem hiding this comment.
Given that I had "bad settings", this should get backed out since the comment is wrong and the code change shouldn't have any effect.
I agree. If we were to opt into caching counts, I think we'd want them to be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem where num_answers gets out of sync with the actual number of answers for the question.
My steps to reproduce:
With this fix, the "no replies" bits become correct.
Three things:
r?