733102 es and db #549
Closed
733102 es and db #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this corrects the queries so the tests test exactly what they're meant to test.
* changed the names of some of the fields indexed to correspond with the model names they derive from * add num_votes to question document index * carry question document index changes through codebase * change answer_vote model maker to answervote * remove excerpting test that's no longer pertinent * remove group_by call which we don't support with ES * add code so when QuestionVote is saved, it updates the index * simplify the pagination code * tweak some TODO and other comments * some other cleanup End result is that a search with ES no longer hits the DB at all but instead pulls everything from the index. Additionally, simplified a bunch of silly stuff out of the ES search view. Note: This requires reindexing.
| @@ -584,6 +601,10 @@ def add_metadata(self, key, value): | |||
| VoteMetadata.objects.create(vote=self, key=key, value=value) | |||
|
|
|||
|
|
|||
| register_for_indexing( | |||
There was a problem hiding this comment.
This is cool. I probably saw this a few times before but now I finally realized how cool it was :-)
There was a problem hiding this comment.
Yeah... so this is something Erik did and while it's kind of neat, I kind of think it does too much and does some of it in magic ways. But I haven't thought of a better way that's as succinct, but more legible and less magic.
|
Nice cleanup, tests pass, looks good r+ |
|
landed in master: ab4919f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oo--I'm using the newly placed "pull request" button that reduces my need to select the branch from the list. I kind of like it.
Anyhow, this fixes some tests, then reworks the search_view_es so it doesn't touch the db at all. Good explanation of what changed in the commit comments.
Things to pay attention to for a peer review:
Mmm... actually that's it. The rest is pretty straight forward.
I think this will have some improvement to performance, but since db activity is cached and it's pretty small already for the search view, I don't think it'll be noticeable like the previous performance changes were.
r?