Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MySQL configuration step in the installation docs #656

Closed
wants to merge 1 commit into from
Closed

Fix MySQL configuration step in the installation docs #656

wants to merge 1 commit into from

Conversation

berkerpeksag
Copy link
Contributor

No description provided.

@willkg
Copy link
Member

willkg commented Jun 18, 2012

Does this make all the mysql command lines look the same? If not, can you go through and make them all look the same in regards to the -u and -p flags?

…user ''@'localhost' to database 'kitsune'| error.
@berkerpeksag
Copy link
Contributor Author

I've updated my patch.

@willkg
Copy link
Member

willkg commented Jun 21, 2012

Awesome! I'll look through this tomorrow.

@willkg
Copy link
Member

willkg commented Jun 22, 2012

Landed in master in 768f0b4

Two things:

  1. In the future, it helps if commit messages conform to good git commit message conventions. In the Kitsune guide, is http://kitsune.readthedocs.org/en/latest/coding.html#git-conventions which refers back to the wrong page in the mozweb bootcamp guide but should refer to http://mozweb.readthedocs.org/en/latest/git.html#commit-messages which talks about how commit messages should look. I fixed your commit message, so it's better.
  2. Thank you! Fixing the docs and making them better helps everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants