[bug 784325] Add display_order and is_listed to forums. #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Our required field monkeypatch was triggering invalid validation. or something like that
| @@ -27,7 +27,8 @@ | |||
|
|
|||
| def forums(request): | |||
| """View all the forums.""" | |||
| qs = Forum.objects.select_related('last_post', 'last_post__author') | |||
| qs = Forum.objects.filter(is_listed=True) | |||
| qs = qs.select_related('last_post', 'last_post__author') | |||
There was a problem hiding this comment.
Why not combine these?:
qs = (Forum.objects.filter(is_listed=True).select_related('last_post', 'last_post__author')
There was a problem hiding this comment.
i will if they fit in the 80 chars
There was a problem hiding this comment.
Hmm, they don't. Is wrapping in a parens and breaking at the . preferred?
There was a problem hiding this comment.
We do this sort of thing in a lot of places in the code:
qs = (Forum.objects.filter(is_listed=True)
.select_related('last_post', 'last_post__author'))
But, "preferred" in this case is really just what we want to do in the Kitsune code. It doesn't really matter much either way.
There was a problem hiding this comment.
I had originally broken the line at the first open ( but I didn't like the result. I'll try this way.
|
Tests pass. It looks ok to me as far as I can tell. r+ |
|
landed 6cf5ab8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r?