[Bug 807470] Make cards fit cards on product page. #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the sidebar, like suggested in the bug, but even with the style changes Bram suggested, long languages like German still made the cards uneven., I added a bit of JS to expand the cards to the same height as the largest in the group. This is noticeable on page load, but it looks just like reflow due to image loading in most cases, so I think it is acceptable.
|
WFM r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the sidebar, like suggested in the bug, but even with the style changes Bram suggested, long languages like German still made the cards uneven., I added a bit of JS to expand the cards to the same height as the largest in the group. This is noticeable on page load, but it looks just like reflow due to image loading in most cases, so I think it is acceptable.
r?