New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1052195 - Select sole verified email by default in the signup page #2976

Merged
merged 1 commit into from Dec 31, 2014

Conversation

Projects
None yet
2 participants
@adusca
Contributor

adusca commented Dec 28, 2014

This will only affect the sign up page for users that don't have a
public email in their github profiles. The default is still the public
email for users that have one.

This also doesn't change anything for users with more than one verified email,
but it would be easy to select one of the verified emails by default.
What do you think is best?

@groovecoder

This comment has been minimized.

Show comment
Hide comment
@groovecoder

groovecoder Dec 30, 2014

Member

IIRC, @stephaniehobson pointed out that if the user has more than 1 verified email on GitHub, we should leave them the option to select whatever.

But, maybe we can default the radio box to their primary email address on GitHub?

Member

groovecoder commented Dec 30, 2014

IIRC, @stephaniehobson pointed out that if the user has more than 1 verified email on GitHub, we should leave them the option to select whatever.

But, maybe we can default the radio box to their primary email address on GitHub?

@groovecoder

This comment has been minimized.

Show comment
Hide comment
@groovecoder

groovecoder Dec 30, 2014

Member

@adusca - since this is adding extra logic, how comfortable do you feel adding a new test (case?) for the SignupView and specifically for the get_form method? If you're not, I can take that on to make sure we have adequate test coverage here.

Member

groovecoder commented Dec 30, 2014

@adusca - since this is adding extra logic, how comfortable do you feel adding a new test (case?) for the SignupView and specifically for the get_form method? If you're not, I can take that on to make sure we have adequate test coverage here.

Bug 1052195 - Select sole verified email by default in the signup page
This will only affect the sign up page for users that don't have a
public email in their github profiles. The default is still the public
email for users that have one.
@adusca

This comment has been minimized.

Show comment
Hide comment
@adusca

adusca Dec 31, 2014

Contributor

I just added a new test case, as we discussed on IRC.

Contributor

adusca commented Dec 31, 2014

I just added a new test case, as we discussed on IRC.

@groovecoder

This comment has been minimized.

Show comment
Hide comment
@groovecoder

groovecoder Dec 31, 2014

Member

Looks good! A potential follow-up is to de-select an email if it's already in use by another account. But that's probably an edge case for those of us who have multiple emails associated with both GitHub and MDN. :)

Member

groovecoder commented Dec 31, 2014

Looks good! A potential follow-up is to de-select an email if it's already in use by another account. But that's probably an edge case for those of us who have multiple emails associated with both GitHub and MDN. :)

groovecoder added a commit that referenced this pull request Dec 31, 2014

Merge pull request #2976 from adusca/bug-1052195
Bug 1052195 - Select sole verified email by default in the signup page

@groovecoder groovecoder merged commit 0e56a53 into mozilla:master Dec 31, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment