Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Bug 1052195 - Select sole verified email by default in the signup page #2976

Merged
merged 1 commit into from
Dec 31, 2014

Conversation

adusca
Copy link
Contributor

@adusca adusca commented Dec 28, 2014

This will only affect the sign up page for users that don't have a
public email in their github profiles. The default is still the public
email for users that have one.

This also doesn't change anything for users with more than one verified email,
but it would be easy to select one of the verified emails by default.
What do you think is best?

@groovecoder
Copy link
Contributor

IIRC, @stephaniehobson pointed out that if the user has more than 1 verified email on GitHub, we should leave them the option to select whatever.

But, maybe we can default the radio box to their primary email address on GitHub?

@groovecoder
Copy link
Contributor

@adusca - since this is adding extra logic, how comfortable do you feel adding a new test (case?) for the SignupView and specifically for the get_form method? If you're not, I can take that on to make sure we have adequate test coverage here.

This will only affect the sign up page for users that don't have a
public email in their github profiles. The default is still the public
email for users that have one.
@adusca
Copy link
Contributor Author

adusca commented Dec 31, 2014

I just added a new test case, as we discussed on IRC.

@groovecoder
Copy link
Contributor

Looks good! A potential follow-up is to de-select an email if it's already in use by another account. But that's probably an edge case for those of us who have multiple emails associated with both GitHub and MDN. :)

groovecoder added a commit that referenced this pull request Dec 31, 2014
Bug 1052195 - Select sole verified email by default in the signup page
@groovecoder groovecoder merged commit 0e56a53 into mdn:master Dec 31, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants